-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[match] fix cache issues in read-only mode #21767
Conversation
@rogerluan , @lacostej, please review. |
I'm OOO till next week, but I'll take a look when I'm back :) |
Sorry, it's a regression I've introduced by implementing a cache for the match 😭. |
@joshdholtz , sorry for the ping. Can you please review and release #21767 and #21766 since there is a regression impacting a lot of folks? |
For reviewers of this PR - I verified and confirmed that this change fixes the issue for me (#21762 (comment)) |
I can also confirm that
fixes #21762 Good job and thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing 🫶
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Resolves #21762 .
Description
The cache can be used only when read-only mode is disabled.
Updates for spec_helper and new test structure copypasted from #21691.
Added test for read-only mode.
Looks better w/o spaces diff.
Testing Steps
Run the match action in read-only mode.